More delimited text bug fixes #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular expression delimiter: fixed non-intuitive behaviour of not including capture groups in the returned fields, and improved behaviour for anchored regular expressions. Added test cases for handling of regular expressions. File encoding: Selected file encoding was being ignored. Fixed and added test cases for file encoding. Bad formatted quoting: Fixed handling of badly formatted quotes (eg unclosed quotes). Added test case. Field names: Where a file had duplicate or blank field names it was not possible to reliably set the names of X,Y,WKT fields. Relocated field name handling to simpler common code in QgsDelimitedTextFile, with automatic renaming of fields with ambiguous or missing names. Add test case for field renaming User interface fixes: Fixed tooltip and other messages throughout. Changed encoding combo box to be alphabetically sorted. Fixed data sample to be refreshed when encoding changed.
ghost
assigned 
|
Whoops .. didn't spot all changes in merge with master. Another update coming shortly |
timlinux
added a commit
that referenced
this pull request
Apr 23, 2013
More delimited text bug fixes
|
Thanks, applied! |
|
@ccrook , fantastic work on CSV support, thanks. I've spotted a bug whereas first point from first row in CSV file is wrongly placed at coordinate x=0, y=0, see http://hub.qgis.org/issues/7688 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tests cases, resultant bug fixes, documentation updates. Main components of this pull request are:
File encoding: Selected file encoding was being ignored. Fixed and
added test cases for file encoding.
Badly formatted quotes: Fixed handling of badly formatted quotes (eg
unclosed quotes). Added test case.
Regular expression delimiter: fixed non-intuitive behaviour (to
perl/python users) of not including capture groups in the returned
fields, and rationalised behaviour for anchored regular expressions.
Added test cases for handling of regular expressions.
Field names: Where a file had duplicate or blank field names it was
not possible to reliably set the names of X,Y,WKT fields. Relocated
field name handling to simpler common code in QgsDelimitedTextFile, with
automatic renaming of fields with ambiguous or missing names. Add test
case for field renaming
Empty records: Removed empty records (eg records containing just
delimiter characters, as often added by Excel)
User interface fixes: Fixed tooltip and other messages throughout.
Changed encoding combo box to be alphabetically sorted. Fixed data
sample grid to be refreshed when encoding changed.
Context help: Added documentation for using delimited text layer in python,
added description of how attributes are loaded and named, general editing.