Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #7072 : can't create a feature when a layer has a join #546

Merged
merged 2 commits into from
Jul 9, 2013

Conversation

PhilippeDorelon
Copy link
Contributor

It works fine with my data but not sure this is the best fix..

@wonder-sk
Copy link
Member

Thanks for contributing the fix. (btw. something must have gone wrong and there are two lines of code on the last line in the diff)

I think the proper fix should actually chop the joined fields, because they are not really a part of the data - the joined fields should be appended automatically whenever someone iterates over layer's features.

@minorua
Copy link
Contributor

minorua commented Apr 30, 2013

works fine for me too. But replacing the conditional expression with the following is enough for the fix? Or is there much better fix?

if ( L->mUpdatedFields.count() != f.attributes().count() )

@PhilippeDorelon
Copy link
Contributor Author

minuora yes your fix works fine and is much simpler than mine : tested with join, added fields and deleted fields.

@ghost ghost assigned wonder-sk May 10, 2013
NathanW2 added a commit that referenced this pull request Jul 9, 2013
Fix #7072 : can't create a feature when a layer has a join
@NathanW2 NathanW2 merged commit aca3dfa into qgis:master Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants