Fix extent computation in QgsVirtualLayerProvider #54976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Oct 18, 2023
nyalldawson
approved these changes
Oct 18, 2023
|
Tests for this already exist in the python base class but only fail when the default constructor for Rectangle builds a Null rather than 0,0,0,0 rectangle - Maybe I should file a PR to do just that (build null) to trigger the many different issues and fix them all in the same PR ? |
strk
force-pushed
the
QgsVirtualLayerProvider-extent
branch
from
ad228e7
to
cb007cf
Compare
Extent should be set to null if there are no rows or geometric field or computed min/max envelope ordinates are null. Also makes the implementation more readable (hopefully).
strk
force-pushed
the
QgsVirtualLayerProvider-extent
branch
from
cb007cf
to
4d8243b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extent should be set to null if there are no rows or geometric field or computed min/max envelope ordinates are null.
Also makes the implementation more readable (hopefully).
Spin-off of GH-54646
Similar to GH-54917