qgswfsparameters: Ensure to get the default value on wrong version #55333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitjano
force-pushed
the
wfs-feature-version-number
branch
2 times, most recently
from
75001c3
to
95801ea
Compare
`QgsWfsParameters::versionAsNumber` creates a `QgsProjectVersion` from the version number defined in the request `VERSION` parameter. If the version is not defined, the version 1.1.0 is used. However, if the version number defined in the `VERSION` parameter is not handled by QGIS (for example 2.0.0), the `QgsProjectVersion` is nver populated which corresponds to use version 0.0.0 instead of 1.1.0, the default value. This issue is fixed by always using version number 1.1.0 if the list of handled versions (`mVersions`) does not contain the requested version.
ptitjano
force-pushed
the
wfs-feature-version-number
branch
from
95801ea
to
4347539
Compare
elpaso
approved these changes
Nov 23, 2023
troopa81
added
backport queued_ltr_backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QgsWfsParameters::versionAsNumbercreates aQgsProjectVersionfromthe version number defined in the request
VERSIONparameter. If theversion is not defined, the version 1.1.0 is used.
However, if the version number defined in the
VERSIONparameter isnot handled by QGIS (for example 2.0.0), the
QgsProjectVersionisnver populated which corresponds to use version 0.0.0 instead of
1.1.0, the default value.
This issue is fixed by always using version number 1.1.0 if the list
of handled versions (
mVersions) does not contain the requestedversion.
Funded by Ifremer