Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-3_34] qgswfsparameters: Ensure to get the default value on wrong version #55380

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[Backport release-3_34] qgswfsparameters: Ensure to get the default value on wrong version #55380

merged 1 commit into from
Dec 21, 2023

Conversation

qgis-bot
Copy link
Collaborator

Backport #55333
Authored by: @ptitjano

@ptitjano @github-actions
qgswfsparameters: Ensure to get the default value on wrong version
990697f 
`QgsWfsParameters::versionAsNumber` creates a `QgsProjectVersion` from
the version number defined in the request `VERSION` parameter. If the
version is not defined, the version 1.1.0 is used.
However, if the version number defined in the `VERSION` parameter is
not handled by QGIS (for example 2.0.0), the `QgsProjectVersion` is
nver populated which corresponds to use version 0.0.0 instead of
1.1.0, the default value.

This issue is fixed by always using version number 1.1.0 if the list
of handled versions (`mVersions`) does not contain the requested
version.
@github-actions github-actions bot added this to the 3.34.1 milestone Nov 23, 2023
@agiudiceandrea agiudiceandrea modified the milestones: 3.34.1, 3.34.2 Nov 25, 2023
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 10, 2023
@github-actions GitHub Actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Dec 17, 2023
@lbartoletti lbartoletti reopened this Dec 21, 2023
@lbartoletti lbartoletti merged commit c044bce into release-3_34 Dec 21, 2023
43 of 44 checks passed
@lbartoletti lbartoletti deleted the backport-55333-to-release-3_34 branch December 21, 2023 13:35
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.34.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qgis-bot @lbartoletti @agiudiceandrea @ptitjano