Don't use thread_local on mingw or OpenBSD builds #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MingW has broken support for thread_local, so force disabling it see https://sourceforge.net/p/mingw-w64/bugs/445/ https://sourceforge.net/p/mingw-w64/bugs/527/ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80816 also OpenBSD has no thread_local support, see https://issues.qgis.org/issues/17351 So on these platforms we fall back to using QThreadStorage. Fixes qgis#17351
nyalldawson
force-pushed
the
thread_local
branch
from
ceff021
to
265be41
Compare
|
Hi @nyalldawson, please don't merge it now. I will build it today on FreeBSD. I think that we have c++11 thread_local. So, some ifdef will be incorrect. |
|
@lbartoletti sure, no rush here. |
|
I have build master and #5504 both works on FreeBSD. We have c++11 thread_local (seems using pthread). |
lbartoletti
reviewed
Nov 6, 2017
CMakeLists.txt
Outdated
| SET (WITH_THREAD_LOCAL TRUE CACHE BOOL "Determines whether std::thread_local should be used") | ||
| MARK_AS_ADVANCED(WITH_THREAD_LOCAL) | ||
|
|
||
| IF (MINGW OR CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR CMAKE_SYSTEM_NAME STREQUAL "OpenBSD") |
There was a problem hiding this comment.
you can remove FreeBSD. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MingW has broken support for thread_local, so force disabling it. See:
https://sourceforge.net/p/mingw-w64/bugs/445/
https://sourceforge.net/p/mingw-w64/bugs/527/
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80816
Also OpenBSD has no thread_local support, see https://issues.qgis.org/issues/17351
So on these platforms we fall back to using QThreadStorage.
Fixes #17351
Supersedes #5504