-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add option to use localhost as redirect host for oauth2 #55419
Conversation
Some oauth2 implementations (eg the MS Sharepoint implementation) do not support http://127.0.0.1 redirects. They allow only https://127.0.0.1 OR http://localhost redirects. Since https is not simple to support, instead expose an option to allow localhost for redirects.
@elpaso look ok to you? |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
@nyalldawson A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@nyalldawson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some oauth2 implementations (eg the MS Sharepoint implementation) do not support http://127.0.0.1 redirects. They allow only https://127.0.0.1 OR http://localhost redirects.
Since https is not simple to support, instead expose an option to allow localhost for redirects.