Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add option to use localhost as redirect host for oauth2 #55419

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

nyalldawson
Copy link
Collaborator

Some oauth2 implementations (eg the MS Sharepoint implementation) do not support http://127.0.0.1 redirects. They allow only https://127.0.0.1 OR http://localhost redirects.

Since https is not simple to support, instead expose an option to allow localhost for redirects.

Some oauth2 implementations (eg the MS Sharepoint implementation)
do not support http://127.0.0.1 redirects. They allow only
https://127.0.0.1 OR http://localhost redirects.

Since https is not simple to support, instead expose an option
to allow localhost for redirects.
@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Nov 27, 2023
@github-actions github-actions bot added this to the 3.36.0 milestone Nov 27, 2023
@nyalldawson
Copy link
Collaborator Author

@elpaso look ok to you?

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@nyalldawson nyalldawson merged commit bc7f89e into qgis:master Nov 28, 2023
41 checks passed
@nyalldawson nyalldawson deleted the oauth_localhost branch November 28, 2023 02:39
Copy link

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#8671
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants