[gui] Fix cursor jump when editing row/column width of a cell in the table designer #55941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
GUI/UX
|
backport to 3.28? |
|
@DelazJ only crash fixes/data corruption fixes should be backported for the final 3.28 release |
|
@nirvn this is a valid test failure |
nirvn
force-pushed
the
manualtableeditor_spin_fix
branch
from
8324c65
to
c7387b4
Compare
|
@nyalldawson , fixed. |
nyalldawson
reviewed
Jan 24, 2024
nirvn
force-pushed
the
manualtableeditor_spin_fix
branch
from
c7387b4
to
be50f5a
Compare
…table designer (fixes qgis#50257)
nirvn
force-pushed
the
manualtableeditor_spin_fix
branch
from
be50f5a
to
9c7a0e3
Compare
nyalldawson
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets rid of needless clearing and re-setting of value in our QgsSpinBox and QgsDoubleSpinBox when setting a custom clear value (setClearValue) or clear value mode (setClearValueMode).
The improvement fixes #50257 , whereas typing a value in the manual table designer's cell row height / column width spin boxes would have the cursor jump at the end of the line edit at every stroke.