-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow point inputs in "Filter vertices by M/Z values" algorithms #55996
Allow point inputs in "Filter vertices by M/Z values" algorithms #55996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! If you can add test, it can be good, but it's not a block for me.
We already have tests for this algorithm using line input. Do you think it makes sense to have identical tests with polygons and points? |
It can prevent future error/regression/whatyouwant ; but it's up to you |
291130a
to
e5c6b7b
Compare
@alexbruy A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
Hi @alexbruy, it seems to me that while the "Filter vertices by M/Z values" algorithms can now have a point vector layer as input, they don't work with single-part point vector layer. See for example the following layers that are identical (apart from the geometry type) and contain 5 features with 1 point each and the Z coordinate ranging from 10 to 50 Executing the "Filter vertices by Z values" with the minimum value parameter set to 30, then the resulting output layer correctly contains 3 features with point's Z coordinate ranging from 30 to 50 if the input layer is the "MultiPointZ" layer, while it incorrectly contains all the 5 input features if the input layer is the "PointZ" layer. Is it expected? |
Also incorporates dca30bd from qgis#55996)
Description
Processing algorithms "Filter vertices by M/Z values" does not accept point layers as input, while "Extract specific vertices" algorithm can be applied to points as well (e.g. to extract some points from multipoint geometry). This is a bit inconsistent behaviour. This PR allows "Filter vertices by M/Z values" to accept point layers to make it uniform with "Extract specific vertices" algorithm.
Fixes #33502.