Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct units in the identify map tool when "map units" are used for distance and area measurements (fix #26995) #56003

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

alexbruy
Copy link
Contributor

Description

In the project properties one can set desired units for elispoidal distance and area measurements, among other values it is possible to select "Map units (…)". When the "Map units(…)" value is selected, some of the "Derived" identify values, namely ellipsoidal area and perimeter does not have units text after the value.

This is because in the project properties "Map units(…)" is represented as an unknown unit (Qgis::DistanceUnit::Unknown and Qgis::AreaUnit::Unknown). As a result, displayDistanceUnits() and displayAreaUnits() method of the identify action return empty string. This also affects conversion of area and perimeter measurements in identify tool.

Fixes #26995.

@alexbruy alexbruy added Map Tools Related to non-digitizing map tools Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jan 25, 2024
@github-actions github-actions bot added this to the 3.36.0 milestone Jan 25, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit d88297c)

@lbartoletti lbartoletti merged commit add57f1 into qgis:master Jan 25, 2024
37 checks passed
@alexbruy alexbruy deleted the identify-tool-show-units branch May 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify features tool does not display the ellipsoid units when "Map units" is chosen
2 participants