Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show warning if width or height of exported image is larger than QPainter limit (refs #41045) #56054

Merged
merged 3 commits into from Jan 30, 2024

Conversation

alexbruy
Copy link
Contributor

Description

When exporting a map to an image via "Project → Import/Export→ Export Map to Image" user can get a truncated output if image width or height hits QPainter limits. To make uses aware about this issue and give them a chance to adjust output image dimensions this PR adds a warning message bar to the "Export Map to Image" dialog.

warning

Refs #41045.

@github-actions github-actions bot added this to the 3.36.0 milestone Jan 29, 2024
@nirvn
Copy link
Contributor

nirvn commented Jan 29, 2024

@nyalldawson , is that still a limitation in Qt 6? I feel we've discussed this in the past for layouts.

@nirvn
Copy link
Contributor

nirvn commented Jan 29, 2024

The message bar here is less than ideal as the dialog is narrow by default and the key part of the message (raster will be truncated) is barely visible. Maybe rephrasing the sentence so the consequence appear before the width/height could work better.

Copy link

github-actions bot commented Jan 29, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit daf02aa)

@alexbruy
Copy link
Contributor Author

Maybe rephrasing the sentence so the consequence appear before the width/height could work better.

Reworded to "Output raster will be truncated, as image width or height is larger than 32768 pixels."

@nirvn
Copy link
Contributor

nirvn commented Jan 29, 2024

@alexbruy , nice.

@alexbruy alexbruy merged commit c7ffbcd into qgis:master Jan 30, 2024
28 checks passed
@alexbruy alexbruy deleted the export-as-image-warning branch January 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants