Fix #17444 : GeoNode data provider completely ignores authentication #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion - hide the authentication group until GeoNode API supports authentication.
nyalldawson
reviewed
Nov 14, 2017
src/gui/qgsnewhttpconnection.h
Outdated
| @@ -56,6 +56,7 @@ class GUI_EXPORT QgsNewHttpConnection : public QDialog, private Ui::QgsNewHttpCo | |||
| enum Flag | |||
| { | |||
| FlagShowTestConnection = 1 << 1, //!< Display the 'test connection' button | |||
| FlagHideAuthenticationGroup = 2 << 2, //!< Hide the Authentication group | |||
There was a problem hiding this comment.
This should be 1 << 2
| @@ -20,14 +20,16 @@ | |||
| #include "qgsgeonodeconnection.h" | |||
| #include "qgsgeonoderequest.h" | |||
|
|
|||
| // For now we are hiding away authentication options since | |||
| // there is no support yet for tication in the GeoNode | |||
There was a problem hiding this comment.
tication -> authentication
| @@ -20,14 +20,16 @@ | |||
| #include "qgsgeonodeconnection.h" | |||
| #include "qgsgeonoderequest.h" | |||
|
|
|||
| // For now we are hiding away authentication options since | |||
| // there is no support yet for tication in the GeoNode | |||
| // We will re-enable this when this limitation changes. TS | |||
There was a problem hiding this comment.
is there a GeoNode ticket number which could be linked here?
|
Thanks @timlinux! |
|
Thanks @timlinux, this looks like a good solution. |
|
Thanks for the inputs @nyalldawson and @elpaso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we deal with this by adding a flag to QgsNewHttpConnection that allows you to hide the authentication group until GeoNode API supports authentication.
With
QgsNewHttpConnection::FlagHideAuthenticationGroupset (in GeoNode connection dialog):With
QgsNewHttpConnection::FlagHideAuthenticationGroupomitted (default behaviour) e.g. in WMS connection dialog:Description
The GeoNode API does not yet support authentication through the API, only from the underlying backend. In the future we will probably work for GeoNode to support authentication through their API but for now we are excluding the authentication options which do nothing which is confusing and misleading to users.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit