Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option 'Use only selected features' to DXF export #56775

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

gacarrillor
Copy link
Member

Enhance DXF export by adding a handy option to filter selected features for each layer. It will be false by default.

This adds to the already existing Extent filter, so that users can apply one of these two options, or even both at the same time.

The new option has also been exposed in the corresponding Processing algorithm.

Screenshots:

image

image


Funded by the QGIS user group Switzerland.

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 8, 2024
@gacarrillor gacarrillor added Feature Processing Relating to QGIS Processing framework or individual Processing algorithms DXF/DWG Relating to DXF or DWG importing/exporting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Mar 8, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Mar 8, 2024

@gacarrillor
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Copy link

github-actions bot commented Mar 8, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit bb8d095)

@@ -267,6 +267,24 @@ class CORE_EXPORT QgsDxfExport : public QgsLabelSink
*/
QgsRectangle extent() const { return mExtent; }

/**
* Use only selected features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be added to QgsDxfExport::Flag instead, and avoid the need for the new getter/setter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Much better, thanks for the suggestion.

@nyalldawson nyalldawson merged commit 9d6471e into qgis:master Mar 12, 2024
30 checks passed
@gacarrillor gacarrillor deleted the dxf_only_selected_features branch March 15, 2024 10:33
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 18, 2024
@qgis-bot
Copy link
Collaborator

@gacarrillor

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. DXF/DWG Relating to DXF or DWG importing/exporting Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants