Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elevation Controller for filtering vertical data in 2d maps #56796

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

nyalldawson
Copy link
Collaborator

This is the equivalent of the temporal controller, but for elevation z-range slicing of data in 2d maps. It's accessed through a new "Data Filtering" submenu in the View menu (in which I've also added Temporal Controller, since that was previously not accessible via menus).

The controller shows as a range slider on the left of the map. There's a configure action for setting the project's elevation range, which dictates the range available from the widget.

This works for all map layers which respect qgis/QGIS-Enhancement-Proposals#201, which are currently point clouds and raster DEMs.

Peek 2024-03-11 15-34

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Mar 11, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 051ffe9)

@uclaros
Copy link
Contributor

uclaros commented Mar 11, 2024

The minimalistic UI looks great! It would be quite useful to also display (or maybe even set) the rangeslider's current upper and lower values.

A widget which allows configuring a slice of a 2d map canvas to show
This is the equivalent of the temporal controller, but for
elevation z-range slicing of data in 2d maps.
@nyalldawson
Copy link
Collaborator Author

This now works (independently!) with secondary canvases too, so that you can interactively slice data in different ways for these canvases:

Peek 2024-03-12 12-45

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff -- one comment on font size that's worth addressing.

@wonder-sk
Copy link
Member

Looking great 👏

Do you plan to have the temporal controller exposed like this at some point as well, or better to keep it in the existing dock widget?

@nyalldawson
Copy link
Collaborator Author

@wonder-sk

I wouldn't be in a hurry to change the temporal controller. That's a lot "heavier" widget (it has many more subcontrols, and the different "modes" it exposes) and the horizontal arrangement works ok as a traditional panel.

@nyalldawson nyalldawson reopened this Mar 12, 2024
Copy link

Tests failed for Qt 5

One or more tests failed using the build from commit 051ffe9

WMS_GetMap_Highlight_Empty_Labels

WMS_GetMap_Highlight_Empty_Labels

Test failed at test_wms_getmap_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getmap.py:1391

Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetMap_Highlight_Empty_Labels/WMS_GetMap_Highlight_Empty_Labels.png (found 271 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@nyalldawson
Copy link
Collaborator Author

Unrelated test failure

@nyalldawson nyalldawson merged commit 2213662 into qgis:master Mar 13, 2024
31 of 33 checks passed
@nyalldawson nyalldawson deleted the elevation_slider branch March 13, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants