-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elevation Controller for filtering vertical data in 2d maps #56796
Conversation
@nyalldawson A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
The minimalistic UI looks great! It would be quite useful to also display (or maybe even set) the rangeslider's current upper and lower values. |
A widget which allows configuring a slice of a 2d map canvas to show
This is the equivalent of the temporal controller, but for elevation z-range slicing of data in 2d maps.
470e689
to
7f972bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff -- one comment on font size that's worth addressing.
Looking great 👏 Do you plan to have the temporal controller exposed like this at some point as well, or better to keep it in the existing dock widget? |
I wouldn't be in a hurry to change the temporal controller. That's a lot "heavier" widget (it has many more subcontrols, and the different "modes" it exposes) and the horizontal arrangement works ok as a traditional panel. |
Tests failed for Qt 5One or more tests failed using the build from commit 051ffe9 WMS_GetMap_Highlight_Empty_LabelsWMS_GetMap_Highlight_Empty_LabelsTest failed at test_wms_getmap_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getmap.py:1391 Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetMap_Highlight_Empty_Labels/WMS_GetMap_Highlight_Empty_Labels.png (found 271 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Unrelated test failure |
This is the equivalent of the temporal controller, but for elevation z-range slicing of data in 2d maps. It's accessed through a new "Data Filtering" submenu in the View menu (in which I've also added Temporal Controller, since that was previously not accessible via menus).
The controller shows as a range slider on the left of the map. There's a configure action for setting the project's elevation range, which dictates the range available from the widget.
This works for all map layers which respect qgis/QGIS-Enhancement-Proposals#201, which are currently point clouds and raster DEMs.