Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dxf] Import/export 'DXF Export' dialog settings from/to XML #56982

Merged
merged 11 commits into from Apr 9, 2024

Conversation

gacarrillor
Copy link
Member

This PR enables users to save and restore GUI settings for the DXF Export dialog, making it possible to export a number of configurations and reuse them or share them with colleagues.

Settings are exported to an XML file (see sample file content).

2024-03-18.15-39-29.mp4

Buttons to save/load to/from DXF Export settings file:

image

Confirmation message before overriding dialog settings with those present in the XML file:

image

Non-blocking confirmation of settings applied:

image


Funded by the QGIS user group Switzerland.

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 27, 2024
@gacarrillor gacarrillor added Feature DXF/DWG Relating to DXF or DWG importing/exporting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Mar 27, 2024
@qgis-bot
Copy link
Collaborator

@gacarrillor
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a review, just some title case suggestions

src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 27, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 0ed9c7d)

@DelazJ
Copy link
Contributor

DelazJ commented Mar 27, 2024

Not for this PR but I think we should try to improve the bottom of this dialog. Looks quite crowded imho.
And @gacarrillor can you in the meantime fix "definedBlocks" spelling on the buttons, please?

@gacarrillor
Copy link
Member Author

gacarrillor commented Mar 27, 2024

Not for this PR but I think we should try to improve the bottom of this dialog. Looks quite crowded imho. And @gacarrillor can you in the meantime fix "definedBlocks" spelling on the buttons, please?

Thanks for your suggestions @DelazJ. All have been addressed in 3eded68

src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
src/app/qgsdxfexportdialog.cpp Outdated Show resolved Hide resolved
@gacarrillor
Copy link
Member Author

@nirvn, thanks for your review, all your comments have been addressed in 6ca63b0

@nirvn nirvn merged commit c67e81b into qgis:master Apr 9, 2024
28 checks passed
@nirvn
Copy link
Contributor

nirvn commented Apr 9, 2024

@gacarrillor , thanks!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Apr 9, 2024

@gacarrillor
A documentation ticket has been opened at qgis/QGIS-Documentation#8998
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DXF/DWG Relating to DXF or DWG importing/exporting Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants