Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Endpoint distance threshold for network analysis #57084

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

nyalldawson
Copy link
Collaborator

Adds an optional end point distance threshold parameter to the network analysis tools. Previously (and still, by default) endpoints will ALWAYS be snapped to the nearest point in the network layer, regardless of how far away from the network they actually are. This can result in meaningless results, as the tools will happily snap points to a road hundreds of kilometers away :)

Now, there's an optional end point distance threshold parameter for these tools. The behaviour of the threshold depends on the algorithm:

  • For the “Service area (from layer)” tool an optional new output was added for “non routable features”. This output will contain any features which were deemed too far from the network. All other features which are within tolerance distance to the network will be stored in the standard output from the tool.
  • For the “Service area (from point)” tool an error will be raised if the point is too far from the network
  • For the “Shortest path (point to point)” tool an error will be raised if either the source or destination points are too far from the network.
  • For the “Shortest path (layer to point)” and “Shortest path (point to layer)” tools:
    • An error will be raised if the point is too far from the network.
    • A new optional output was added for “non routable features”. This output will contain any features which were deemed too far from the network. All other features which are within tolerance distance to the network will be stored in the standard output from the tool.

Sponsored by City of Canning

Adds an optional end point distance threshold parameter to the
network analysis tools. Previously (and still, by default) endpoints
will ALWAYS be snapped to the nearest point in the network layer,
regardless of how far away from the network they actually are. This
can result in meaningless results, as the tools will happily snap
points to a road hundreds of kilometers away :)

Now, there's an optional end point distance threshold parameter
for these tools. The behaviour of the threshold depends on the
algorithm:

- For the “Service area (from layer)” tool an optional new output
was added for “non routable features”. This output will contain
any features which were deemed too far from the network. All
other features which are within tolerance distance to the
network will be stored in the standard output from the tool.
- For the “Service area (from point)” tool an error will be raised
if the point is too far from the network
- For the “Shortest path (point to point)” tool an error will
be raised if either the source or destination points are too far
from the network.
- For the “Shortest path (layer to point)” and “Shortest path (point
to layer)” tools:
  - An error will be raised if the **point** is too far from the network.
  - A new optional output was added for “non routable features”. This
    output will contain any features which were deemed too far from the
    network. All other features which are within tolerance distance to
    the network will be stored in the standard output from the tool.

Sponsored by City of Canning
@nyalldawson nyalldawson added Feature Processing Relating to QGIS Processing framework or individual Processing algorithms Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Apr 8, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Apr 8, 2024

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Apr 8, 2024

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.38.0 milestone Apr 8, 2024
@nyalldawson nyalldawson merged commit 7355c24 into qgis:master Apr 19, 2024
43 checks passed
@nyalldawson nyalldawson deleted the network_analysis_tthreshold branch April 19, 2024 22:50
@qgis-bot
Copy link
Collaborator

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9029
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants