[Processing] GRASS Support multiple vector output file formats #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice |
|
For consistency, maybe place geopackage and shape file formats on top, followed by an alphabetical list of additional formats? That's what we now do elsewhere. |
|
Nice, it is very important to avoid v.external being the default import method in favor of v.in.ogr (which got improved again in GRASS GIS 7.4.0) |
ghost
mentioned this pull request
8 tasks
alexbruy
reviewed
Jan 17, 2018
| @@ -193,6 +223,48 @@ def getSupportedOutputRasterExtensions(): | |||
| allexts.append(ext) | |||
| return allexts | |||
|
|
|||
| @staticmethod | |||
| def getSupportedVectors(): | |||
There was a problem hiding this comment.
Same as above. If I'm not wrong QgsVectorFileWriter already has methods for getting such information
| vector = False | ||
| raster = False | ||
| # Is it an OGR driver? | ||
| if (gdal.DCAP_VECTOR in metadata |
There was a problem hiding this comment.
Maybe better to rely on the core API here, e.g. supportedFiltersAndFormats() and other methods of the QgsRasterFileWriter class?
|
@medspx can you rebase? I will be happy to merge it after this |
8 tasks
8 tasks
|
Superseded by #6996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add multiple vector output file formats with v.out.ogr:
New formats:
OGR output options:
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit