Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing representation of layer's custom property list in the info page (HtmlMetadata) #57490

Merged
merged 4 commits into from
May 23, 2024

Conversation

signedav
Copy link
Contributor

@signedav signedav commented May 20, 2024

This covers lists and in only one level deepness.

Other types that cannot be converted to a string or a stringlist are not represented (by the text value cannot be displayed).

image

("weirdoType" is manually added with type "Map")

It probably makes sense to have a more powerful representation, but then I suggest to go deeper into the content like proposed here #57335 But this is IMHO an extension and not scope of this small "fix" here.

This fixes #57334

@github-actions github-actions bot added this to the 3.38.0 milestone May 20, 2024
@signedav signedav changed the title Representing layer's custom property list in the info page (HtmlMetadata) Fix missing representation of layer's custom property list in the info page (HtmlMetadata) May 20, 2024
@signedav
Copy link
Contributor Author

Is this what you imagine @DelazJ ?
Does the implementation make sense for you @jadsilva ?

Copy link

github-actions bot commented May 20, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 351b955)

@DelazJ
Copy link
Contributor

DelazJ commented May 20, 2024

Is this what you imagine @DelazJ ?

Yes because now the variables are all displayed so the bug is fixed. Thanks @signedav
No 😄 because the matching variable name <-> value is not necessarily obvious, and assuming I understood your suggestion, displaying the variables name/value next to each other in a table would provide a better user experience. For the next step?

@signedav
Copy link
Contributor Author

displaying the variables name/value next to each other in a table would provide a better user experience. For the next step?

Yes exactly, I think it would make sense to improve the UX there in another (independent) step, but I would like to have this here as a fix of the bug, that the values are not displayed at all...

src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
@signedav
Copy link
Contributor Author

signedav commented May 22, 2024

Thanks @nyalldawson Now it evaluates the QMetaType according to the Qt version and makes the conversion according to it.

src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson reopened this May 22, 2024
@nyalldawson nyalldawson merged commit 7779613 into qgis:master May 23, 2024
28 of 29 checks passed
@signedav signedav deleted the stringlist-info branch May 23, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom properties variableNames and variableValues are cleared when more than one layer custom variable exist
4 participants