[Processing] creategrid: Allow negative overlay #57709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The creategrid algorithm had a limit of 0 to 1000000000.0. I'm removing this limitation to go beyond this maximum limit, but above all to allow a negative limit, which in fact allows an empty space (the opposite of superposition).
lbartoletti
added
Processing
nyalldawson
reviewed
Jun 7, 2024
| @@ -110,8 +110,8 @@ QVariantMap QgsGridAlgorithm::processAlgorithm( const QVariantMap ¶meters, Q | |||
| if ( mGridExtent.height() < mVSpacing ) //check if grid extent is smaller than vertical spacing | |||
| throw QgsProcessingException( QObject::tr( "Vertical spacing is too large for the covered area." ) ); | |||
|
|
|||
| if ( mHSpacing <= mHOverlay || mVSpacing <= mVOverlay ) | |||
| throw QgsProcessingException( QObject::tr( "Invalid overlay: horizontal: '%1', vertical: '%2'" ).arg( mHOverlay ).arg( mVOverlay ) ); | |||
| // if ( mHSpacing <= mHOverlay || mVSpacing <= mVOverlay ) | |||
There was a problem hiding this comment.
Let's just remove these lines
nyalldawson
approved these changes
Jun 7, 2024
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-57709-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 2fc7dfeca70030d152502692ab49c36bfc3e3e53
# Push it to GitHub
git push --set-upstream origin backport-57709-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backportsThen, create a pull request where the |
qgis-bot
added
the
failed backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The creategrid algorithm had a limit of 0 to 1000000000.0. I'm removing this limitation to go beyond this maximum limit, but above all to allow a negative limit, which in fact allows an empty space (the opposite of superposition).
Graphically, this allows:
cc @florentfgrs
Sponsored by: Oslandia and Elements