Adds missing tooltips #5773
Merged
Adds missing tooltips #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
approved these changes
Nov 30, 2017
| @@ -1798,6 +1831,9 @@ | |||
| </item> | |||
| <item row="1" column="0"> | |||
| <widget class="QToolButton" name="mAddLayerRestrictionButton"> | |||
| <property name="toolTip"> | |||
| <string>Add layer to exclude</string> | |||
There was a problem hiding this comment.
I don't know the context, but maybe clearer Add layer to the exclude list or ... to the list of excluded layers
There was a problem hiding this comment.
You are right. I think it was a mistake.
There was a problem hiding this comment.
Can you update the PR so we can merge?
There was a problem hiding this comment.
I will. But I can only do it on Monday.
|
this is the context for those tool tips. Do you think they still need changes? "Add layers to exclude" and "Add composer to exclude" |
|
@SrNetoChan no, probably it's fine as it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some missing toolTips in some dialog's buttons.
Tooltips are useful for users to understand what the button will do, but also for documentation. It's easier to expalin the user to "click the Add color button" than "click the button with the plus sign".
I have also found some wrong tool tips in the metadata widget, but I will try to address that in a different PR.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit