do not list non spatial in custom layer order widget #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Jan 19, 2018
src/core/layertree/qgslayertree.cpp
Outdated
| { | ||
| QgsLayerTreeLayer *nodeLayer = findLayer( layerId ); | ||
| if ( nodeLayer ) | ||
| { | ||
| // configuration from 2.x projects might have non spatial layers | ||
| QgsMapLayer *layer = nodeLayer->layer(); | ||
| if ( layer->type() == QgsMapLayer::VectorLayer ) |
There was a problem hiding this comment.
QgsMapLayer has isSpatial (always true for rasters), so you could avoid all the casting to vectors here.
There was a problem hiding this comment.
thanks for the reminder!
fixed
3nids
force-pushed
the
layerorder_nonspatial
branch
from
e66a989
to
d43f1fc
Compare
nyalldawson
approved these changes
Jan 20, 2018
This was referenced May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17887