[processing] fixes and improvements for ''Add unique value index field" alg #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And implement some fixes/improvements (refs discussion on the dev mailing list): - allow user to specify created field name - allow optional creation of a summary table showing new class value vs original value
|
+1, great to see basic algs such as this one ported to c++ prior to final release. It improves the modeler experience too. |
|
Thanks @nirvn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References recent discussion on the dev mailing list - this adds some improvements to the "Add unique value index field" algorithm, and ports the algorithm to c++.