[needs-docs][processing] move providers actions into the processing panel toolbar #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
processing_tools
branch
from
fecd15a
to
1f19f00
Compare
nyalldawson
reviewed
Jan 24, 2018
| @@ -149,19 +149,6 @@ def _filterItem(self, item, text): | |||
| show = (showChild or show) and item not in list(self.disabledProviderItems.values()) | |||
| item.setHidden(not show) | |||
| return show | |||
| elif isinstance(item, (TreeAlgorithmItem, TreeActionItem)): | |||
There was a problem hiding this comment.
isn't this still needed for TreeAlgorithmItem?
nirvn
force-pushed
the
processing_tools
branch
from
5ff393b
to
f585ab7
Compare
|
@nyalldawson , comment addressed. |
|
@alexbruy , are you OK with this change? |
nirvn
force-pushed
the
processing_tools
branch
from
f585ab7
to
04fd761
Compare
|
Looks good to me. |
|
Hi @nirvn thanks for these improvements!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have a toolbar in our processing panel, it's time we (finally) move provider actions out of the algorithms tree.
This PR moves the provider actions into dedicated toolbar buttons:
IMHO, this makes a lot more sense. First, those actions were not algorithms to begin with, and second, it increases the visibility of those actions, which includes the creation of modes and scripts as well as access to online collections.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit