Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbmanager] Fixes empty table #6553

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

pblottiere
Copy link
Member

@pblottiere pblottiere commented Mar 7, 2018

Description

This PR fixes an issue introduced by 777fdeb.

See https://issues.qgis.org/issues/18352.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@Gustry
Copy link
Contributor

Gustry commented Mar 7, 2018

LGTM, it works. Thanks for the fix!

@pblottiere
Copy link
Member Author

I launched Travis builds several times without success due to an issue with ProcessingQgisAlgorithmsTest.

Considering that it has nothing to do with the current bugfix, I'll merge this PR tomorrow if i have no objections in the meantime.

@nyalldawson nyalldawson closed this Mar 8, 2018
@nyalldawson nyalldawson reopened this Mar 8, 2018
@nyalldawson
Copy link
Collaborator

That should be fixed now - I think some library on travis updated and threw out the reference hash value.

@pblottiere
Copy link
Member Author

Nice, thank you @nyalldawson, Travis is green now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants