[dbmanager] move shortcut in the tooltip

[Gustry]

Description

@pblottiere introduced the new "Cancel" button in #6268 in the DB manager.

I moved the shortcut label in tooltip instead of in the main button label.

( Message moved to https://issues.qgis.org/issues/18352 )

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include fixes #11111 in the commit message next to the description
• Commits which add new features are tagged with [FEATURE] in the commit message
• Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
• I have read the QGIS Coding Standards and this PR complies with them
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit

[m-kuhn]

@Gustry I find it hard to follow what's going on here.
Is this pull request about a change in tooltips? How is killing QGIS because of long queries and @pblottiere involved in this?
Thanks for a clarification.

[haubourg]

Something related to explicit locking maybe ?

[Gustry]

Sorry for the confusion. My PR is related to the new "cancel" button introduced by @pblottiere in #6268 . I'm just moving the shortcut as a tooltip.

Then, I was pinging @pblottiere on my issue, which related to his feature. I can't display tables anymore in the DB Manager. My screenshot is not related to this PR.

@haubourg I opened master, I can't see any result since the new cancel button. Then I opened 3.0 at the same time, it's working perfectly.

[m-kuhn]

Can you open an issue on the tracker or comment on the original cancel button, so we can strictly use this thread here for the review process of your improvements?

[Gustry]

@m-kuhn PR cleaned from the side issue and ticket created: https://issues.qgis.org/issues/18352
Sorry for that.

[m-kuhn]

Thanks a lot @Gustry no we can merge this without forgetting about the other issue

[pblottiere]

@Gustry

Salut Etienne,

I opened master, I can't see any result since the new cancel button. Then I opened 3.0 at the same time, it's working perfectly.

Sorry for the delay and inconvenience (I made a mistake during the review :/).

I proposed a PR to fix the issue #6553. Let me know!