Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.18 Server: return empty image in GetLegendGraphis if no layer is there #6792

Merged
merged 2 commits into from
Apr 17, 2018
Merged

2.18 Server: return empty image in GetLegendGraphis if no layer is there #6792

merged 2 commits into from
Apr 17, 2018

Conversation

mhugent
Copy link
Contributor

@mhugent mhugent commented Apr 13, 2018

Especially important for contextual legends. Otherwise the server returns nothing and the client receives an 'internal server error 500'

elpaso
elpaso approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! IIRC there should be also an open issue on the tracker for this bug.

rldhont
rldhont requested changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test ?

@gioman
Copy link
Contributor

gioman commented Apr 13, 2018

@mhugent thanks for tackling this regression!

@nyalldawson nyalldawson added the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Apr 16, 2018
@mhugent mhugent merged commit 673fafb into qgis:release-2_18 Apr 17, 2018
@rldhont
Copy link
Contributor

rldhont commented Apr 20, 2018

@mhugent is the test ported in release-3_0 and master ?

@mhugent
Copy link
Contributor Author

mhugent commented Apr 20, 2018

@rldhont: no
Isn't it enough to port it to master?

@rldhont
Copy link
Contributor

rldhont commented Apr 24, 2018

@mhugent to avoid regression I have ported the test to master and release-3_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont requested changes

@elpaso elpaso elpaso approved these changes

Assignees
No one assigned
Labels
Requires Tests! Waiting on the submitter to add unit tests before eligible for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhugent @gioman @rldhont @elpaso @nyalldawson