Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG icons for project and layer actions #700

Merged
merged 1 commit into from
Jul 12, 2013
Merged

SVG icons for project and layer actions #700

merged 1 commit into from
Jul 12, 2013

Conversation

3nids
Copy link
Member

@3nids 3nids commented Jul 5, 2013

the story goes on...

Here a new set for project and layer actions icons.
layericons

and for oracle:
oracle

Last version in this pull request:
0last2
zy
zz

also these icons:
Overview remove all: 00overview-remove
Overview add all: 00overview-addall
Overview add 00overview-add
Oracle: oracle
Duplicate composer: 00duplicate-composer

@NathanW2
Copy link
Member

NathanW2 commented Jul 5, 2013

Hey Denis,

I'm liking the new icons, however I think we could simplify the Add Layer
ones even more. I'm keen to see what they look like without the white page
and little edge bit on the lower left corner bit behind each one, making
the blue provider icon larger.

  • Nathan

On Fri, Jul 5, 2013 at 7:49 PM, Denis Rouzaud notifications@github.comwrote:

the story goes on...

Here a new set for project and layer actions icons.
[image: layericons]https://f.cloud.github.com/assets/127259/752994/33c8fac8-e558-11e2-958d-70968a71ed8c.png

and for ocale:

[image: oracle]https://f.cloud.github.com/assets/127259/752990/1bed0174-e558-11e2-9b66-ac2c4ce838b4.png

You can merge this Pull Request by running

git pull https://github.com/3nids/Quantum-GIS svgaddlayers

Or view, comment on, or merge it at:

#700
Commit Summary

  • SVG icons for project and layer actions

File Changes

Patch Links:

@3nids
Copy link
Member Author

3nids commented Jul 5, 2013

Yey, they might look a bit heavy.
However, removing the corner won't give more room for the blue icon because of the "+".
Would you remove the grey rectangle, the corner or both?

@mach0
Copy link
Member

mach0 commented Jul 5, 2013

I like the idea of having the Postgis and the Spatialite but the MSSQL? uh? cannot find that online :) but probably better that way before we run into licence issues :)
Well done! .. I like them all

@bstroebl
Copy link

bstroebl commented Jul 5, 2013

Hi Denis,
I do really like the Postgres icon. How about MySql, wouldn' t their dolphin make more sense?
How about writing "csv" in the csv-button instead of the comma?

@borysiasty
Copy link
Member

I'd avoid putting any texts to icons, as it could be a danger precedent. The next would be W*S buttons and so on...

Let me complain a bit about other icons ;p I prefer the old light brown color for creating new stuff (save as, new printout, new layer). Those buttons make some well visible orientation points in the toolbars. Also I don't like the new FileOpen, it's too crowdy and visually below the line.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 5, 2013

Using spatialite and postgres icons is great!

I would leave the color yellow (or another very light color) for any action involving "new"
dark blue and dark green are not very well distinguishable.

I would also love to see some simplified "add layer" icons like @NathanW2 mentioned. Maybe it's possible to have a more uniform look for the W[CMT]S as well, having the white page at the same size (or not at all) just like the other icons do.

@bstroebl
Copy link

bstroebl commented Jul 5, 2013

Borys,
good point, I did not think about that. However the comma is still too unintuitive for me, although it is a lot better than the old one which I spent some minutes searching for about an hour ago.

@3nids
Copy link
Member Author

3nids commented Jul 5, 2013

Here is the "new" in yellow.
I am not a big fan, because the blue gives a better contrast and gives more coherence to the toolbar in terms of colors.
blue_vs_yellow
Everybody agrees on keeping the yellow for "new" actions?

By the way, I am colour-blind ;)

@NathanW2
Copy link
Member

NathanW2 commented Jul 5, 2013

I'm a fan of the yellow but from a colour blind point of view I can see how
it is a pain.

IMO the composer icons should be changed. The first one should just be a
single page like normal as it is only opening a single composer. The
second one for the composer manager I have never been a fan of because it
looks like it creates many composer which it doesn't do. I don't know what
would look good for a composer manager icon and I can live with what is
there for now.

On Fri, Jul 5, 2013 at 9:45 PM, Denis Rouzaud notifications@github.comwrote:

Here is the "new" in yellow.
I am not a big fan, because the blue gives a better contrast and gives
more coherence to the toolbar in terms of colors.
[image: blue_vs_yellow]https://f.cloud.github.com/assets/127259/753443/3c1afd92-e568-11e2-993a-8da174b0adc4.png
Everybody agrees on keeping the yellow for "new" actions?

By the way, I am colour-blind ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20515081
.

@3nids
Copy link
Member Author

3nids commented Jul 5, 2013

file-layer_v2

here we go:

  • simpler version of the w*s icons though I am not 100% convinced
  • put back yellow in new
  • put a wrench for print composer

@NathanW2
Copy link
Member

NathanW2 commented Jul 5, 2013

Personally I like those new icons.

I think the open project just needs to be a simple open folder other that
than that +1 from me.

On Fri, Jul 5, 2013 at 10:50 PM, Denis Rouzaud notifications@github.comwrote:

[image: file-layer_v2]https://f.cloud.github.com/assets/127259/753649/49509a90-e571-11e2-8d33-4c7291c604d1.png

here we go:

  • simpler version of the w*s icons though I am not 100% convinced
  • put back yellow in new
  • put a wrench for print composer

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20517374
.

@3nids
Copy link
Member Author

3nids commented Jul 5, 2013

OK, here's another one with a blue folder:
filev3

@dakcarto
Copy link
Member

dakcarto commented Jul 5, 2013

Hi Denis,

I like your latest set. Thank you for your work on this! Couple of comments:

  1. The latest 'open project' icon doesn't match the 2D style of the rest. The original icon was fine, just too small, too light and too much below center line.
  2. The basic blue color for the 'add layer' icons is too monotonous. It would be best to add color to the icons, preferably colors that match the original project's icons, e.g.:
    • Maybe pale red for spatialite feather (color of its globe), since a blue arrow denotes SQLite, which is a bit off the mark.
    • Maybe a brighter blue for the Postgres elephant.
    • Maybe a dark red for MSSQL icon
    • Maybe the comma of CVS (which I like) would be more recognizable if it were plain old black.
    • Adding some color to the W*S servers would help too, though not sure what colors are representative there.
  3. I think the 'add layer' icons are still unnecessarily complex. There seems to be two identifying background graphics denoting a layer: the lower-left right-angle lines and a rectangle. One graphic should suffice, like you did with the W*S servers, but I think it should be the rectangle, not the right-angle lines.
  4. There is also a 'Duplicate layer' icon that needs to match any new 'Delete layer' icon style.

Some icons you may want to work on next to help with consistency:

  • Database Manager icon doesn't match new default theme at all.
  • Add to Overview icon is OK, but the Add All... and Remove All... icons are leftovers from the previous theme.
  • What's This icon is just plain ugly (not sure why the What's This context help is not used more in the app).
  • Manage and Install Plugins... (new plugin manager) should probably have a new icon since the tool is now different. The green puzzle/plugin icon with a wrench or cog overlay would work.

@3nids
Copy link
Member Author

3nids commented Jul 8, 2013

Here's a new set:
00last

also these icons:
Overview remove all: 00overview-remove
Overview add all: 00overview-addall
Overview add 00overview-add
Oracle: 00oracle
Duplicate layer: 00duplicate-layer
Duplicate composer: 00duplicate-composer

I think it's getting better!

@timlinux
Copy link
Member

timlinux commented Jul 8, 2013

Hi

I Like the less visual clutter on the add layer icons (simplified page). I know it has been discussed before, but do we even need that page component? For me it would be enough to have the principle element and the plus icon.

Regards

Tim

@timlinux
Copy link
Member

timlinux commented Jul 8, 2013

Oh I also preferred the blue mssql layer icon over the red one.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 8, 2013

I agree, having all "add layer" icons blue apart from oracle and mssql makes these two look like they are something special.

@NathanW2
Copy link
Member

NathanW2 commented Jul 8, 2013

Denis,

Could we just see what it looks like without the page behind and all the
icons blue.

  • Nathan

On Mon, Jul 8, 2013 at 10:00 PM, Matthias Kuhn notifications@github.comwrote:

I agree, having all "add layer" icons blue apart from oracle and mssql
makes these two look like they are something special.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20600673
.

@3nids
Copy link
Member Author

3nids commented Jul 8, 2013

here we go!
1last1
oracle

@timlinux
Copy link
Member

timlinux commented Jul 8, 2013

Well those (add layer) icons look absolutely gorgeous! Well done!

Some more comments:

  • The oracle layer icon is the odd one out here - what about using a more serif font based 'O' for it?
  • The help metaphor of a life ring is kinda old and doesnt have good connotations (our application might make you feel like you are drowning). What about using a book metaphor rather? Also removing the red colour from the help and using blue would be nicer.
  • The remove layer icon - what about shifting the rect to the top left of the icon?
  • The open project folder - what about removing the gradient and making it more of a flat yellow (since other icons dont really use gradients).

Regards

Tim

@dakcarto
Copy link
Member

dakcarto commented Jul 8, 2013

Hi Denis,

Please create a different pull request for icons not associated with the concept of this request, i.e. the help icons. IMHO, combining them with this request will lead to critiquing issues.

I agree with Tim's assessment, the new 'add layer' icons look great excepting where he noted. However, I think the command badge (e.g. the remove component of 'Remove layer') should stay where it is for consistency sake.

Regarding the use of a simple rectangle to denote a map layer. There is already a good and simple GIS theme icon for that (with curled left edge):

map map-remove
mapset-add

I think that curled edge rectangle should be used for the base layer component for basic layer actions, if we are going to move to no rectangles behind the add layer icons. In the GIS theme the double map icon denotes a map set, so maybe something slightly different needs done for the Duplicate layer icon, like cascading the two layers from upper left to lower right instead with the upper left on top:

map-dup

@anitagraser
Copy link
Member

+1 for Tim's suggestion "The open project folder - what about removing the gradient and making it more of a flat yellow (since other icons dont really use gradients)."

@Cracert
Copy link
Contributor

Cracert commented Jul 8, 2013

Hi Denis and others,
I'm very glad that you present your point of view as a mock-up. This makes our discussion much easier and faster. I appreciate your work, although not always agree with some proposals. In a while will write some comments about it to mailing list...

First approach to new QGIS theme was too explicit. We put 'layer'+'wms'+'add'. This guides us to redundancy (add+layer). Probably we can just skip redundant parts and make all 'add layer' icons without 'add layer'!
What do you think about this idea with respect to 'add layer' icons only? Two such examples below.

Variation on Oracle logo. Can you see 'Oracle data base'? ;)
db-oracle

Microsoft database case was much easier.
db-mssql

SVG source files are in OSGeo Graphics

  • Postgres and SQLite icons are much better, but I would use another (different) colours.
  • W*S icons are nice, but too similar. Let me propose some alternatives based on original GIS icons theme.
  • 'Duplicate layer' ideas goes in wrong direction; brainstorm is needed
  • @timlinux: Help icon should be changed
  • remove layer icon must have 'L' element at bottom left; otherwise it is 'rectangle'
  • @dakcarto: layer - map - mapset are all different types; let's leave layer as
    layer-remove

Proposal: let's share, not duplicate our work.

@3nids
Copy link
Member Author

3nids commented Jul 9, 2013

I have uptaded the icons with a book for the help, and I put back the "L" on the remove layer (also align on grid, thanks Robert).

Also, here is a new duplicate icon:
duplicate-layer

Oracle: the O is designed as in the logo
see http://calipia.files.wordpress.com/2011/10/logo-oracle.jpg

Mssql logo is trademark, so I wouldn't play too close to it.

We already tried to change the colors, but I think it is nicer with al icons in blue.
I prefer with the icons with the green "+".

Here is the new set:
0last2

@bstroebl
Copy link

bstroebl commented Jul 9, 2013

+1 to keep the green "+" to illustrate "add" (as opposed to "remove" and
"new"), makes the whole bar look more consistent IMHO.

Bernhard

Am 09.07.2013 08:11, schrieb Denis Rouzaud:

I have uptaded the icons with a book for the help, and I put back the
"L" on the remove layer (also align on grid, thanks Robert).

Also, here is a new duplicate icon:
duplicate-layer
https://f.cloud.github.com/assets/127259/766328/effcea54-e85c-11e2-9504-8cf352b95d8a.png

Oracle: the O is designed as in the logo
oracle
https://a248.e.akamai.net/camo.github.com/eab01b35d74ee03c827129f046625930d98ace36/687474703a2f2f63616c697069612e66696c65732e776f726470726573732e636f6d2f323031312f31302f6c6f676f2d6f7261636c652e6a7067

Mssql logo is trademark, so I wouldn't play too close to it.

We already tried to change the colors, but I think it is nicer with al
icons in blue.
I prefer with the icons with the green "+".

Here is the new set:
0last2
https://f.cloud.github.com/assets/127259/766354/5eca647e-e85e-11e2-9890-cafff54bb6b7.png

—
Reply to this email directly or view it on GitHub
#700 (comment).

__________ Information from ESET Mail Security, version of virus signature database 8543 (20130708) __________

The message was checked by ESET Mail Security.
http://www.eset.com

@NathanW2
Copy link
Member

NathanW2 commented Jul 9, 2013

+1 for all blue icons for me too. The W*S ones might be a little
complicated but we can work on that.

Personally I'm not a fan of the L thing in the corner, most users wouldn't
even know it's there nor what it stands for.

On Tue, Jul 9, 2013 at 4:11 PM, Denis Rouzaud notifications@github.comwrote:

I have uptaded the icons with a book for the help, and I put back the "L"
on the remove layer (also align on grid, thanks Robert).

Also, here is a new duplicate icon:
[image: duplicate-layer]https://f.cloud.github.com/assets/127259/766328/effcea54-e85c-11e2-9504-8cf352b95d8a.png

Oracle: the O is designed as in the logo
[image: oracle]https://a248.e.akamai.net/camo.github.com/eab01b35d74ee03c827129f046625930d98ace36/687474703a2f2f63616c697069612e66696c65732e776f726470726573732e636f6d2f323031312f31302f6c6f676f2d6f7261636c652e6a7067

Mssql logo is trademark, so I wouldn't play too close to it.

We already tried to change the colors, but I think it is nicer with al
icons in blue.
I prefer with the icons with the green "+".

Here is the new set:
[image: 0last2]https://f.cloud.github.com/assets/127259/766354/5eca647e-e85e-11e2-9890-cafff54bb6b7.png

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20655279
.

@3nids
Copy link
Member Author

3nids commented Jul 9, 2013

0last3

@3nids
Copy link
Member Author

3nids commented Jul 9, 2013

I have no clear opinion for the L guy...I can live with or without him ;)

@dakcarto
Copy link
Member

dakcarto commented Jul 9, 2013

+1 for totally removing the 'L' thingy from all icons. IMHO it adds complexity without adding coherency. Not sure why I think that, since it is not much different than the yellow diamond badge on the Composer icons (and similar badges). Maybe because it is exterior, thin and closely parallel to the layer rectangle. More than likely it is just a matter of my taste. :^)

Denis, layer icons are looking good. They are distinctive enough now in shape to not need color. Maybe the W*S icons are a bit too complex yet (still better than before, though).

Small thing: the spatialite icon is still just an SQLite icon, and does not have the other components of the spatialite icon (globe and ring). Maybe trying out a version that has those elements would be nice. If it doesn't work, the plain SQLite feather is fine, and a good, logical fallback.

The help icon as a 3D perspective book doesn't match, though. More of a 2D or 2.5D icon would be better.

Thanks again for all your work on this.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

Removed the L from duplicate and remove layer.
And I tried to simplify the W*S icons:

zz

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

Regarding the globe for spatialite I don't think it's a good idea. It will be way too complex. Also, it's the same principle for postgis: we have the postgres icon. Also, I used a custom feather. Would you try with the regular one: http://commons.wikimedia.org/wiki/File:SQLite370.svg ???

I will put a new help icon soon.

@NathanW2
Copy link
Member

This W*S icons are looking better. Maybe the inner lines of the WFS one
need to be a little litter so the vector bit sticks out more.

On Wed, Jul 10, 2013 at 3:28 PM, Denis Rouzaud notifications@github.comwrote:

Removed the L from duplicate and remove layer.
And I tried to simplify the W*S icons:

[image: zz]https://f.cloud.github.com/assets/127259/772833/7a91d566-e921-11e2-8b9f-8c08bb66a37f.png

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20722367
.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

new WFS:
zy

new help, accord What's this? font:
zz

@NathanW2
Copy link
Member

Yep they look good. I like the help book too.

On Wed, Jul 10, 2013 at 4:07 PM, Denis Rouzaud notifications@github.comwrote:

new WFS:
[image: zy]https://f.cloud.github.com/assets/127259/772942/f46b001a-e926-11e2-83c2-b02cb405c429.png

new help, accord What's this? font:
[image: zz]https://f.cloud.github.com/assets/127259/772944/f88eebb6-e926-11e2-8d3b-ff3606e3fa3b.png

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20723344
.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

I like it too. It's funny how the simplest ideas are working! But sadly they are not coming to mind first...

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

If we are ok to go, I can rebase into a single commit.

@NathanW2
Copy link
Member

Rebase it into a single commit anyway.

On Wed, Jul 10, 2013 at 4:17 PM, Denis Rouzaud notifications@github.comwrote:

If we are ok to go, I can rebase into a single commit.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/700#issuecomment-20723583
.

@timlinux
Copy link
Member

Looking very nice - +1 from me to merge the layer add and help/whats this icons.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

done

@NathanW2
Copy link
Member

@dakcarto

since it is not much different than the yellow diamond badge on the Composer icons (and similar badges)"

Personally I don't they need to be there too. A simple page would be fine.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

with a blue one?
zt

@anitagraser
Copy link
Member

+1 very nice help and icons!

I agree with Nathan that the diamond badge on the composer icons seems unnecessary. Is it supposed to resemble a north arrow.

@3nids
Copy link
Member Author

3nids commented Jul 10, 2013

Thanks.
Well, it's just a diamond, no idea if it's supposed to represent something.
I removed them from the 3 composer icons.

@timlinux
Copy link
Member

Can you make it mergable so I can test?

Thanks

Tim

@3nids
Copy link
Member Author

3nids commented Jul 12, 2013

done!

NathanW2 added a commit that referenced this pull request Jul 12, 2013
@NathanW2
Merge pull request #700 from 3nids/svgaddlayers
8c7723f 
SVG icons for project and layer actions
@NathanW2 NathanW2 merged commit 8c7723f into qgis:master Jul 12, 2013
@NathanW2
Copy link
Member

@timlinux I think these look great so I merged them for wider testing. We can fix any little issues in master.

@3nids 3nids deleted the svgaddlayers branch July 24, 2014 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@3nids @NathanW2 @mach0 @bstroebl @borysiasty @m-kuhn @dakcarto @timlinux @anitagraser @Cracert