[bugfix] Fix double escaping of colon in QgsMimeDataUtils #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#19195 - WMS layer loaded in incorrect CRS when using drag and drop from Browser panel
elpaso
changed the title
nyalldawson
reviewed
Jun 18, 2018
src/core/qgsmimedatautils.cpp
Outdated
| @@ -206,11 +206,13 @@ QByteArray QgsMimeDataUtils::layerTreeNodesToUriList( const QList<QgsLayerTreeNo | |||
| QString QgsMimeDataUtils::encode( const QStringList &items ) | |||
| { | |||
| QString encoded; | |||
| // Do not escape colon twice | |||
| QRegExp re( "([^\\\\]):" ); | |||
There was a problem hiding this comment.
Use the recommended replacement QRegularExpression instead.
This could possibly be made a bit cleaner by a negative look behind.
nyalldawson
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19195 - WMS layer loaded in incorrect CRS when using drag and drop from Browser panel