Resurrect display of interpolated z/m in identify results #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add closest point x/y (closest point on geometry) Add tests Fixes qgis#19403
m-kuhn
reviewed
Aug 14, 2018
src/gui/qgsmaptoolidentify.cpp
Outdated
| @@ -374,6 +374,25 @@ void QgsMapToolIdentify::closestVertexAttributes( const QgsAbstractGeometry &geo | |||
| } | |||
| } | |||
|
|
|||
| void QgsMapToolIdentify::closestPointAttributes( const QgsAbstractGeometry &geometry, const QgsPointXY &layerPoint, QMap<QString, QString> &derivedAttributes ) | |||
| { | |||
| QgsPoint closestPoint = QgsGeometryUtils::closestPoint( geometry, QgsPoint( layerPoint.x(), layerPoint.y() ) ); | |||
There was a problem hiding this comment.
Should we have a QgsPoint::toPointXY method and vice versa.
There was a problem hiding this comment.
Actually there's already QgsPointXY( const QgsPoint &point ), I'll just use that
There was a problem hiding this comment.
Maybe we just want to remove the explicit part there for the direction QgsPointXY -> QgsPoint (and leave it for the other one)
There was a problem hiding this comment.
Implicit conversions scare me 😨
There was a problem hiding this comment.
Just look at it as upcasting ;)
QgsMapLayer* l = myVectorLayer; // ok
QgsVectorLayer* l = myMapLayer; // not gonna be that easy
m-kuhn
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.qgis.org/issues/19403, and adds tests