Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add layer filter in snapping configuration #7735

Merged
merged 3 commits into from
Aug 31, 2018
Merged

add layer filter in snapping configuration #7735

merged 3 commits into from
Aug 31, 2018

Conversation

3nids
Copy link
Member

@3nids 3nids commented Aug 28, 2018

@3nids
Copy link
Member Author

3nids commented Aug 28, 2018

image

@@ -86,6 +89,7 @@ class APP_EXPORT QgsSnappingLayerTreeModel : public QSortFilterProxyModel
bool nodeShown( QgsLayerTreeNode *node ) const;

QgsProject *mProject = nullptr;
QString mFilterText = QString();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to initialise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nirvn
Copy link
Contributor

nirvn commented Aug 29, 2018

UI placement isn't fantastic, is there any way we could improve it? Full disclosure: I don't have any bright ideas. I assume you haven't placed the search box next to the [ snapping on intersection ] button to have the search box show up when using the snapping toolbar's layers "pop-up" panel.

Maybe just a text label to the left of the search box would already help balance things a bit? "Filter displayed layers by name: [blah________________________]" ?

@nyalldawson nyalldawson added this to the 3.4 milestone Aug 29, 2018
@nyalldawson nyalldawson added the Requires Changes! Waiting on the submitter to make requested changes label Aug 31, 2018
@3nids
Copy link
Member Author

3nids commented Aug 31, 2018

now, there is two distinct layouts:

image

image

@3nids 3nids added Feedback Waiting on the submitter for answers and removed Requires Changes! Waiting on the submitter to make requested changes labels Aug 31, 2018
@nirvn
Copy link
Contributor

nirvn commented Aug 31, 2018

Looking much better! I think we'd benefit from a "Filter layers" placeholder text on the widget.

Also, for the panel layout, IMHO, the widget would look better below the layer tree. For e.g.:
screenshot from 2018-08-31 11-40-43

@3nids
Copy link
Member Author

3nids commented Aug 31, 2018

here we go
image

@nirvn
Copy link
Contributor

nirvn commented Aug 31, 2018

@3nids , you could possibly even de-complexity code and always have that filter widget at the bottom, if that looks good to you.

@3nids
Copy link
Member Author

3nids commented Aug 31, 2018

ok....went for it...
image

@3nids
Copy link
Member Author

3nids commented Aug 31, 2018

I think it's better, otherwise the dialog has to be quite wide due to the 3 buttons with text.

@nirvn
Copy link
Contributor

nirvn commented Aug 31, 2018

@3nids , I think it looks good too. Nice little feature addition 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feedback Waiting on the submitter for answers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants