-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add layer filter in snapping configuration #7735
Conversation
src/app/qgssnappinglayertreemodel.h
Outdated
@@ -86,6 +89,7 @@ class APP_EXPORT QgsSnappingLayerTreeModel : public QSortFilterProxyModel | |||
bool nodeShown( QgsLayerTreeNode *node ) const; | |||
|
|||
QgsProject *mProject = nullptr; | |||
QString mFilterText = QString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to initialise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
UI placement isn't fantastic, is there any way we could improve it? Full disclosure: I don't have any bright ideas. I assume you haven't placed the search box next to the [ snapping on intersection ] button to have the search box show up when using the snapping toolbar's layers "pop-up" panel. Maybe just a text label to the left of the search box would already help balance things a bit? "Filter displayed layers by name: [blah________________________]" ? |
@3nids , you could possibly even de-complexity code and always have that filter widget at the bottom, if that looks good to you. |
I think it's better, otherwise the dialog has to be quite wide due to the 3 buttons with text. |
@3nids , I think it looks good too. Nice little feature addition 👍 |
https://youtu.be/x4Yybg1rqgE