Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Range widget (partial)fix for modeler. Fixes #19785 #7825

Merged
merged 3 commits into from
Sep 7, 2018

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Sep 7, 2018

Description

This PR allow to add in modeler and without error, scripts or algs using QgsProcessingParameterRange. In this moment there is no complete integration e.g. the range parameter can't be used as input/output in the modeler, but it's a start point allowing to add algorithm without modifiy them to QgsProcessingParameterNumber as workaround to be used in modeler.
Added also tests for the RangePanel.

fix promoted inside GeoMove [1] project for Cartolab [2] (A Coruña university)

[1] http://cartolab.udc.es/geomove/
[2] http://cartolab.udc.es

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@luipir luipir changed the title [processing] Range widget (partial)fix for modeler [processing] Range widget (partial)fix for modeler. Fixes #19785 Sep 7, 2018
@luipir
Copy link
Contributor Author

luipir commented Sep 7, 2018

discussion started at https://issues.qgis.org/issues/19785 can follow here!

@nyalldawson nyalldawson merged commit 8fa5b04 into qgis:master Sep 7, 2018
@luipir luipir deleted the range_widget_fix_for_modeler branch September 9, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants