Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19825 where MultipleLayers python widget stays empty #7864

Merged

Conversation

olivierdalang
Copy link
Contributor

Description

Fixes as small bug in the Processing modeler where MultipleLayerWidget doesn't show other layers from the model if type is TypeMapLayer.

Looks like a small mistake in the code as the condition elif self.parameterDefinition().layerType() == QgsProcessing.TypeVector: in python/plugins/processing/gui/wrappers.py:642 is duplicated.

Please review carefully as I just started looking it that area of the code.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • I have run the scripts/prepare-commit.sh script before each commit

@olivierdalang
Copy link
Contributor Author

Backport is here : #7882

Let me know if this is the right way to do it as I may have some other small contributions these days :-)

@nyalldawson nyalldawson modified the milestones: 3.4, 3.4.0 Sep 14, 2018
@nyalldawson
Copy link
Collaborator

Removing backport tag as 3.2 is EOLed

@nyalldawson nyalldawson merged commit 953ea96 into qgis:master Sep 15, 2018
@nyalldawson
Copy link
Collaborator

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants