Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "Link class boundaries" option next to class definition #8287

Closed
wants to merge 2 commits into from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Oct 23, 2018

Current
linkboundaries-old

Proposed linkboundaries-new

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 26, 2018

ping?

@nirvn
Copy link
Contributor

nirvn commented Oct 26, 2018

@DelazJ , this change is problematic, will prevent shrinking the style panel.

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 26, 2018

@nirvn Ah! indeed I forgot that panel! However are you sure it will prevent shrinking? I think that panel can still be shrunk (might need to reduce the horizontal spacer default width). The single "issue" I see is that the minimal width to see all the items in the dialog would need to expand but just a bit. Here's how it looks like using the minimal width to see all widgets (just few missing pixels ;)).
layer_styling_graduated

And there's already an issue with the layer styling panel: when browsing the different embedded widgets (color, symbols...) you often have to resize or horizontally scroll in order to see the items on the right (eg data-defined buttons or drop-down button) so, not really a new issue imho (or it would fix that given that the "minimal" size used for the main dialog will allow visibility of all items in other "pages").

All that said, no strong opinion about the future of this PR ;)

@nirvn
Copy link
Contributor

nirvn commented Oct 26, 2018

The single "issue" I see is that the minimal width to see all the items in the dialog would need to expand but just a bit.

That's my point, that the width would be expanded. Just a bit is already a lot 😉 it's also just a bit in English, but if your interface is in another language, the labels can expand, etc.

Let's try to find another way to improve this UI.

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 26, 2018

That's my point, that the width would be expanded. Just a bit is already a lot 😉 it's also just a bit in English, but if your interface is in another language, the labels can expand, etc.

Agreed. I Had that in mind but didn't want to use it against myself (me not honest? nooo!)
May be a pushbutton in replacement with appropriate tooltip? No expansion in that case.

@stale
Copy link

stale bot commented Nov 9, 2018

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 9, 2018
@stale
Copy link

stale bot commented Nov 16, 2018

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants