Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Optionally use a map theme to render terrain textures #8509

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

wonder-sk
Copy link
Member

Often it is useful to have a different map theme for terrain in 3D view than the map theme used in the main map canvas.

Often it is useful to have a different map theme for terrain in 3D view
than the map theme used in the main map canvas.
@nyalldawson
Copy link
Collaborator

Do map themes apply to 3d render settings too?

Code here looks good, but could you add a test?

@nyalldawson nyalldawson added this to the 3.6 milestone Nov 21, 2018
@wonder-sk
Copy link
Member Author

Do map themes apply to 3d render settings too?

Themes are only applied as an override of map theme for terrain texture. 3D renerer settings of map layers are used from whatever is the current map theme.

Code here looks good, but could you add a test?

Added in afd3525 with few fixes

@nyalldawson
Copy link
Collaborator

. 3D renerer settings of map layers are used from whatever is the current map theme.

Is this by design? Or just due to not-yet-implemented features? I think as a user I'd expect the 3d canvas to behave similar to the 2d canvas here and switch to the entirety of the selected theme.

@wonder-sk
Copy link
Member Author

Is this by design? Or just due to not-yet-implemented features?

To be honest I haven't thought much about 3D renderers of map layers. My aim really was to be able to use different texture for the terrain than what the main canvas displays, so for example some map layers with 3D renderers wouldn't get rendered in 2D map too. Having themes support for 3D map layer renderers could be nice, but that's a lower priority for me. So I guess that is a not-yet-implemented feature rather than unsupported by design.

@nyalldawson
Copy link
Collaborator

Ok. If it was by design I'd have an issue, but if it's just not implemented then I've no issue!

@wonder-sk wonder-sk merged commit d4ef55d into qgis:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants