Make URLS in message log clickable #8915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice!
…On Mon, Jan 21, 2019 at 10:36 AM Nyall Dawson ***@***.***> wrote:
Makes URLS in the message log clickable. This uses the approach from
https://stackoverflow.com/questions/33531632/how-to-catch-the-link-click-event-in-qplaintextedit.
, avoiding a need to switch to the slow QTextBrowser widget.
------------------------------
You can view, comment on, or merge this pull request online at:
#8915
Commit Summary
- Make URLS in message log clickable
File Changes
- *M* python/gui/auto_generated/qgsmessagelogviewer.sip.in
<https://github.com/qgis/QGIS/pull/8915/files#diff-0> (2)
- *M* src/gui/qgsmessagelogviewer.cpp
<https://github.com/qgis/QGIS/pull/8915/files#diff-1> (42)
- *M* src/gui/qgsmessagelogviewer.h
<https://github.com/qgis/QGIS/pull/8915/files#diff-2> (5)
Patch Links:
- https://github.com/qgis/QGIS/pull/8915.patch
- https://github.com/qgis/QGIS/pull/8915.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8915>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXS3KRBz8Iy0x6K7vSiie32JVRWYe8qks5vFQt8gaJpZM4aJ78S>
.
|
|
@NathanW2 is that a +1 to merge? |
|
Looks good to me.
…On Mon, Jan 21, 2019 at 11:32 AM Nyall Dawson ***@***.***> wrote:
@NathanW2 <https://github.com/NathanW2> is that a +1 to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8915 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXS3LEl4Ng0TmGul-OIqi1ArKHcnNVVks5vFRi-gaJpZM4aJ78S>
.
|
|
+1, nice one. |
|
Thanks @nyalldawson ! Helpfull! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes URLS in the message log clickable. This uses the approach from https://stackoverflow.com/questions/33531632/how-to-catch-the-link-click-event-in-qplaintextedit. , avoiding a need to switch to the slow QTextBrowser widget.