Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URLS in message log clickable #8915

Merged
merged 1 commit into from
Jan 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/gui/auto_generated/qgsmessagelogviewer.sip.in
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ Logs a ``message`` to the viewer.

virtual void reject();

virtual bool eventFilter( QObject *obj, QEvent *ev );


};

Expand Down
42 changes: 42 additions & 0 deletions src/gui/qgsmessagelogviewer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <QPlainTextEdit>
#include <QScrollBar>
#include <QDebug>
#include <QDesktopServices>

QgsMessageLogViewer::QgsMessageLogViewer( QWidget *parent, Qt::WindowFlags fl )
: QDialog( parent, fl )
Expand Down Expand Up @@ -70,6 +71,7 @@ void QgsMessageLogViewer::logMessage( const QString &message, const QString &tag
{
w = new QPlainTextEdit( this );
w->setReadOnly( true );
w->viewport()->installEventFilter( this );
tabWidget->addTab( w, cleanedTag );
tabWidget->setCurrentIndex( tabWidget->count() - 1 );
}
Expand Down Expand Up @@ -116,3 +118,43 @@ void QgsMessageLogViewer::closeTab( int index )
else
tabWidget->removeTab( index );
}

bool QgsMessageLogViewer::eventFilter( QObject *object, QEvent *event )
{
switch ( event->type() )
{
case QEvent::MouseButtonPress:
{
if ( QPlainTextEdit *te = qobject_cast<QPlainTextEdit *>( object->parent() ) )
{
QMouseEvent *me = static_cast< QMouseEvent *>( event );
mClickedAnchor = ( me->button() & Qt::LeftButton ) ? te->anchorAt( me->pos() ) :
QString();
if ( !mClickedAnchor.isEmpty() )
return true;
}
break;
}

case QEvent::MouseButtonRelease:
{
if ( QPlainTextEdit *te = qobject_cast<QPlainTextEdit *>( object->parent() ) )
{
QMouseEvent *me = static_cast< QMouseEvent *>( event );
QString clickedAnchor = ( me->button() & Qt::LeftButton ) ? te->anchorAt( me->pos() ) :
QString();
if ( !clickedAnchor.isEmpty() && clickedAnchor == mClickedAnchor )
{
QDesktopServices::openUrl( mClickedAnchor );
return true;
}
}
break;
}

default:
break;
}

return QDialog::eventFilter( object, event );
}
5 changes: 5 additions & 0 deletions src/gui/qgsmessagelogviewer.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,14 @@ class GUI_EXPORT QgsMessageLogViewer: public QDialog, private Ui::QgsMessageLogV
protected:
void closeEvent( QCloseEvent *e ) override;
void reject() override;
bool eventFilter( QObject *obj, QEvent *ev ) override;

private slots:
void closeTab( int index );

private:

QString mClickedAnchor;
};

#endif