[processing][needs-docs] add missed "srcnodata" parameter to the buildvrt algorithm (fix #20586) #8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
approved these changes
Jan 21, 2019
| options=self.RESAMPLING_OPTIONS, | ||
| defaultValue=0) | ||
| resampling.setFlags(resampling.flags() | QgsProcessingParameterDefinition.FlagAdvanced) | ||
| self.addParameter(resampling) | ||
|
|
||
| src_nodata_param = QgsProcessingParameterString(self.SRC_NODATA, | ||
| self.tr('Nodata value(s) for input bands'), |
There was a problem hiding this comment.
I think you should explicitly state "space separated" here -- my gut instinct would have been to use a comma separated list
(fix #20586). Without this parameter it is not possible to remove collars surrounding input raster which may overlap with other input rasters. As this is very frequent case algorithm is useless without such parameter. To keep API compatibility new parameter is optional and not used by default.
|
Travis failure is unreleated to this PR |
8 tasks
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this parameter it is not possible to remove collars surrounding input raster which may overlap with other input rasters. As this is very frequent case algorithm is useless without such parameter. To keep API compatibility new parameter is optional and not used by default. Fixes https://issues.qgis.org/issues/20586
Tests included.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit