Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processing ] various backports #8944

Merged
merged 3 commits into from Jan 22, 2019
Merged

[processing ] various backports #8944

merged 3 commits into from Jan 22, 2019

Conversation

alexbruy
Copy link
Contributor

Description

Backports fixes from #8930 and #8927 to LTR branch. IMHO while these fixes introduce new parameters they also solve quite annoying issues and make corresponding tools usable in very frequent use cases.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@alexbruy
[processing] add optional EXTRA parameter to gdalwarp algorithm (fix #…
f74c280 
…20721)

This allows users to pass additional command-line arguments which are
not exposed in the algorithm definition. The most frequent use case is
enabling transparency and adding nodata values.

(cherry picked from commit bb2c366)
@alexbruy
[processing] add missed "srcnodata" parameter to the buildvrt algorithm
42b2bc7 
(fix #20586).

Without this parameter it is not possible to remove collars surrounding
input raster which may overlap with other input rasters. As this is very
frequent case algorithm is useless without such parameter. To keep API
compatibility new parameter is optional and not used by default.

(cherry picked from commit dc2b29c)
@alexbruy
add note about format of the srcnodata parameter
139659c 
(cherry picked from commit 133b405)
@nyalldawson
Copy link
Collaborator

I think this is acceptable - I've certainly seen quite a few bug reports regarding the missing options.

@alexbruy alexbruy merged commit 3de1550 into qgis:release-3_4 Jan 22, 2019
@alexbruy alexbruy deleted the processing-bakports branch January 22, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexbruy @nyalldawson