Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the GRASS v_net modules #9044

Closed
wants to merge 1 commit into from
Closed

Conversation

gioman
Copy link
Contributor

@gioman gioman commented Jan 31, 2019

Description

For some reason in QGIS 3 a fundamental "-s" flag was not added in the v.net GRASS modules.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson
Copy link
Collaborator

Can we get some unit tests here?

@alexbruy
Copy link
Contributor

@gioman unfortunatelly this does not fix all issues, e.g. v.net still failed to produce output even with this change. I was working on more complete PR (#9046) and did not noticed that you already submitted this.

@gioman
Copy link
Contributor Author

gioman commented Jan 31, 2019

@alexbruy redmine is slow sending out notifications, so I didn't noticed https://issues.qgis.org/issues/19904#note-13. Anyway as my patch is not complete we can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants