Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GRASS v.net modules (fix #19904) [processing] #9046

Merged
merged 5 commits into from
Feb 1, 2019
Merged

fix GRASS v.net modules (fix #19904) [processing] #9046

merged 5 commits into from
Feb 1, 2019

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Jan 31, 2019

Description

There are several issues with GRASS v.net modules in Processing:

  • points does not snapped to the network by default
  • v.net failed to produce output even if points snapped to the network
  • stdout handling is broken in all GRASS algorithms
  • broken v.net.report and v.net.nreport modules

This PR addresses these issues. Fixes https://issues.qgis.org/issues/19904 and https://issues.qgis.org/issues/21142

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@PedroVenancio
Copy link
Contributor

Hi @alexbruy ,

I also found this issue in v.net.salesman https://issues.qgis.org/issues/21142

Do you think it can be 'easily' fixed and added to this PR?

@alexbruy
Copy link
Contributor Author

@PedroVenancio I will look into it.
Regarding v.net.report and v.net.nreport looks like they are removed from GRASS, I can't find them in the GRASS docs

@PedroVenancio
Copy link
Contributor

Thank you very much @alexbruy !

Regarding v.net.report and v.net.nreport looks like they are removed from GRASS, I can't find them in the GRASS docs

They are part of v.net as different operations
https://grass.osgeo.org/grass76/manuals/v.net.html

But I've never used them, I don't know much about them.

@alexbruy alexbruy merged commit ecd306e into qgis:master Feb 1, 2019
@alexbruy alexbruy deleted the grass-v-net branch February 1, 2019 06:03
@PedroVenancio
Copy link
Contributor

Thank you very much @alexbruy !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants