Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add SLD 1.0 export for rasters #9162

Merged
merged 25 commits into from Feb 19, 2019

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Feb 12, 2019

Description

Backport of #9049
The PR add the ability to export QGIS raster style as SLD 1.0 with geoserver flavours

The PR has been sponsored by Geosolution [1]

[1] https://www.geo-solutions.it/

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@luipir luipir added the Feature label Feb 12, 2019
@luipir luipir changed the title Backport of Add SLD 1.0 export for rasters [needs-docs] Backport of Add SLD 1.0 export for rasters Feb 12, 2019
@m-kuhn m-kuhn changed the title [needs-docs] Backport of Add SLD 1.0 export for rasters Backport of Add SLD 1.0 export for rasters Feb 18, 2019
@m-kuhn m-kuhn added the Backport Is a backport of another pull request label Feb 18, 2019
@jodygarnett
Copy link

jodygarnett commented Feb 19, 2019

GeoServer PSC is interested in seeing this backport made available to our GeoServer users (we gathered together several funding sources and a few folks did personal contributions to make it happen).

Reference:

@nyalldawson
Copy link
Collaborator

I doubt you'll get anyone explicitly approve this backport and take responsibility here.... But... It's been a week with no objections. That usually indicates it's ok to proceed.

@luipir
Copy link
Contributor Author

luipir commented Feb 19, 2019

@nyalldawson I was in doubt how to read this silence

@luipir luipir merged commit c88e7ab into qgis:release-3_4 Feb 19, 2019
@luipir
Copy link
Contributor Author

luipir commented Feb 19, 2019

@jodygarnett
Copy link

How should I word that? Should we not wait until this PR shows up in an update?

@luipir
Copy link
Contributor Author

luipir commented Feb 19, 2019

sure... just put it in the todo list

@jodygarnett
Copy link

jodygarnett commented Feb 20, 2019

Okay checked the roadmap, so this will be in 3.4.5 due out shortly ... I can use that so it will be "correct". Done...

jodygarnett added a commit to geoserver/geoserver that referenced this pull request Feb 20, 2019
jodygarnett added a commit to geoserver/geoserver that referenced this pull request Feb 20, 2019
@luipir luipir deleted the rasterSLD_export_backport-3_4 branch February 21, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Is a backport of another pull request Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants