-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GRASS 76 on Mac #9174
Conversation
This is a continuation of 8db3dea
@pmav99 should it be backported? |
@luipir I guess it wouldn't hurt. |
BTW, now that I look at it better, it would probably make sense to reverse the list's ordering. I.e. use this: for version in ['76', '74', '72', '71', '70', '7', '']: instead of this: for version in ['', '7', '70', '71', '72', '74', '76']: Is it OK if I |
IMHO make sense to get the highest version in case more than one version is installed. I'm not used to have multiple qgis version, so I do not exactly what would be the expected behaviour. If we change the logic we can introduce regressions. If we leave this logic a user that want the latest version will use the lowet version before and would be aware of this => forcing to remove the older one. not clear to me what is the best solution. BTW We can invert the search logic without great risks to create regressions. please do a separate commit to invert the list. |
maybe the hardcoded logic is not the best way how to handle this. I assume it would be easy to get all the directories starting with "grass" and using the one with the highest number (or alternatively the first one because I do not think you can have multiple of those)? |
@PeterPetrik I strongly agree... but we had cases where there here mutiple installation like "grass-7-svn"... there is no a standard way but sometimes could depend on packaging. |
Looks good. |
@pmav99 can you open a backport pull request? |
@m-kuhn sure, to which branch? |
Exactly |
Please start with searching the newest GRASS GIS version first (I see no point in preferring older over newer versions) |
+1 with @neteler "start with searching the newest GRASS GIS version first" qgis#9174 (comment) cc @rhurlin
+1 with @neteler "start with searching the newest GRASS GIS version first" #9174 (comment) cc @rhurlin
This is a continuation of 8db3dea#diff-a0af97520c54a563bb843be614410af8