Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8725 (Fast rendering) and #8733 (Better formating scales) and fix #8776 #922

Closed
wants to merge 4 commits into from
Closed

Conversation

ahuarte47
Copy link
Contributor

#8725: Fast rendering of LineStrings and Polygons pre-applying a view threshold filter to the geometries to render in qgis. View Table of test results in 'http://hub.qgis.org/issues/8725'
#8733: Better formating scales
#8776: Set the canvas color in 'qgsprojectproperties::apply()' before refresh

The ComboBox load the scale values as "1.000.000" instead of "1000000"
Fast rendering of LineStrings and Polygons pre-applying a view threshold
filter to the geometries to render in qgis.
View Table of test results in 'http://hub.qgis.org/issues/8725'
Fast rendering of LineStrings and Polygons pre-applying a view threshold
filter to the geometries to render in qgis.
View Table of test results in (http://hub.qgis.org/issues/8725)
@ahuarte47 ahuarte47 closed this Oct 6, 2013
@ahuarte47 ahuarte47 reopened this Oct 6, 2013
@gioman
Copy link
Contributor

gioman commented Oct 6, 2013

Hi Alvaro, thanks for the patches, I will try them asap! Meanwhile can you change the title of this pull request with one more descriptive? So the devs will understand better what is about (and is a big deal!). Thanks!

@ahuarte47
Copy link
Contributor Author

Ok, thanks.
I have a problem, this pull fixes two independent issues. I don't know how to separate them.

set the canvas color in 'qgsprojectproperties::apply()' before refresh
@strk
Copy link
Contributor

strk commented Oct 7, 2013

@ahuarte47, you could create a branch for each topic (from master) and cherry-pick relevant commits in each, then send a pull request from there.

@ahuarte47
Copy link
Contributor Author

Thanks, I get it, I'll organize my repository.

@ahuarte47 ahuarte47 closed this Oct 8, 2013
@blazek
Copy link
Member

blazek commented Oct 9, 2013

Please consider using of qgis_bench executable (tests/bench) instead of adding new class for statistics.

@ahuarte47
Copy link
Contributor Author

Ok thanks, now it is unused with a disabled #define. I have added this "temporal" class for demostrate the % of simplification of the geometries without visible changes. Finally it must be deleted.

If you wish, I delete it.

@ahuarte47
Copy link
Contributor Author

Please, I have closed this pull, it has commits containing different issues, test the pull 927 for test the implementation of the issue #8725, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants