Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Update external layer management #9385

Merged
merged 7 commits into from
Mar 19, 2019
Merged

[server] Update external layer management #9385

merged 7 commits into from
Mar 19, 2019

Conversation

pblottiere
Copy link
Member

Description

Update external layers management for consistency with highlight layers.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@pblottiere pblottiere added the API API improvement only, no visible user interface changes label Mar 5, 2019
@pblottiere pblottiere added this to the 3.8 milestone Mar 5, 2019
@m-kuhn m-kuhn changed the title Update external layer management [server] [server] Update external layer management Mar 5, 2019
nyalldawson
nyalldawson reviewed Mar 6, 2019
View reviewed changes
src/server/services/wms/qgswmsparameters.cpp Outdated
const QStringList layers = allLayersNickname();
for ( const QString &layer : allLayersNickname() )
{
if ( ! isExternalLayer( layer ) )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like playing with c++11 std algorithms this is a great candidate for a std::remove_if type filter 😉

src/server/services/wms/qgswmsrenderer.cpp Outdated Show resolved Hide resolved
@pblottiere
Copy link
Member Author

Thanks for your review @m-kuhn and @nyalldawson 👍!

@pblottiere
Copy link
Member Author

I'll merge this PR tomorrow if I don't have more comments in the meantime.

@pblottiere pblottiere merged commit 1e8aec4 into qgis:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn left review comments

@nyalldawson nyalldawson nyalldawson left review comments

Assignees
No one assigned
Labels
API API improvement only, no visible user interface changes
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@pblottiere @mhugent @m-kuhn @nyalldawson