Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Move parsing of DXF parameters in QgsWmsParameters... #9560

Merged
merged 10 commits into from
Mar 25, 2019

Conversation

pblottiere
Copy link
Member

Description

...to be consistent with other WMS requests.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@pblottiere pblottiere added the API API improvement only, no visible user interface changes label Mar 19, 2019
@pblottiere pblottiere added this to the 3.8 milestone Mar 19, 2019
@pblottiere
Copy link
Member Author

Considering that we do not have unit tests for DXF format (which is a shame :(), @rldhont @elpaso @mhugent, could you do a quick review on this PR please? It's mainly copy/paste.

@pblottiere
Copy link
Member Author

I added some unit tests on the getDxf method of the renderer, so I'm more confident :).

I'll merge this PR in the coming days if I don't have any comments.

@pblottiere pblottiere merged commit 250c626 into qgis:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API improvement only, no visible user interface changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant