[Backport release-3_6] of SRCHEIGHT/SRCWIDTH for GetLegendGraphic request #9727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
reviewed
Apr 5, 2019
This was referenced Apr 9, 2019
|
I'm not a C++ reviewer, I can't comment on that sorry ;-) |
mbernasocchi
requested review from
pblottiere and
elpaso
and removed request for
pblottiere and
elpaso
pblottiere
reviewed
Apr 11, 2019
| /** | ||
| * Returns SRCWIDTH parameter or an empty string if not defined. | ||
| * \returns srcWidth parameter | ||
| * \since QGIS 3.8 |
pblottiere
reviewed
Apr 11, 2019
| * converted. | ||
| * \returns srcWidth parameter | ||
| * \throws QgsBadRequestException | ||
| * \since QGIS 3.8 |
pblottiere
reviewed
Apr 11, 2019
| /** | ||
| * Returns SRCHEIGHT parameter or an empty string if not defined. | ||
| * \returns srcHeight parameter | ||
| * \since QGIS 3.8 |
pblottiere
reviewed
Apr 11, 2019
| * converted. | ||
| * \returns srcHeight parameter | ||
| * \throws QgsBadRequestException | ||
| * \since QGIS 3.8 |
pblottiere
approved these changes
Apr 11, 2019
|
Thanks @signedav 👍! |
|
Thanks to you as well @pblottiere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes these values as map size in case of GetLegendGraphics Request and still HEIGHT and WIDTH if not a GetLegendGraphics Request.
Backport of #9545