-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading tf to 2.4.0 #280
Conversation
Have you tried our tests with tf2.4? I just tried and I get the following failure
because we are using Note that pip still installs tf2.3.1 by default (unless we explicitly do |
Yes, sorry for not being more explicit, this should be a draft PR to fix this https://github.com/Quantum-TII/qibo/network/alert/requirements.txt/tensorflow/open. As soon as pypi uploads the final tf release we can go ahead and fix/test the changes. |
@stavros11 this should be ready to go. |
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 10712 10716 +4
=========================================
+ Hits 10712 10716 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, for me it works with tf2.4 on CPU. I could not test on GPU yet due to the CUDA issue (tf2.4 requires CUDA 11 while I had 10.1).
I would expect this to be fine on GPU but if you already have a tf2.4 GPU configuration installed in any machine it would be great to confirm this by running the tests there.
@stavros11 I have checked using anaconda with python38, tf2.4.0 cuda11. Tests are passing on GPU. I will retry on other systems and then merge. |
I confirm that tests are passing even with python3.9 and cuda 11.1. |
No description provided.