Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update in readout optimization protocols #602

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Nov 2, 2023

Closes #599.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Nov 2, 2023
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.6 milestone Nov 2, 2023
@andrea-pasquale andrea-pasquale self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #602 (60d9819) into main (158e7e6) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   96.24%   96.14%   -0.10%     
==========================================
  Files          96       96              
  Lines        6551     6594      +43     
==========================================
+ Hits         6305     6340      +35     
- Misses        246      254       +8     
Flag Coverage Δ
unittests 96.14% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...zation/readout_optimization/resonator_amplitude.py 100.00% <100.00%> (ø)
...zation/readout_optimization/resonator_frequency.py 99.00% <100.00%> (+0.10%) ⬆️
...readout_optimization/twpa_calibration/frequency.py 100.00% <100.00%> (ø)
...t_optimization/twpa_calibration/frequency_power.py 100.00% <100.00%> (ø)
...ion/readout_optimization/twpa_calibration/power.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 6d3de62 Nov 7, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_twpa_update branch November 7, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update also iq_angle and threshold in twpa protocols
3 participants