Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak on 'class multipart_reader' #114

Closed
wants to merge 1 commit into from

Conversation

vrqq
Copy link
Contributor

@vrqq vrqq commented Jul 1, 2019

Simply fix issue #113 by saving buffer data into std::string.

It's a runnable version, at least, without crashing but (maybe?) decline in performance.

@vrqq vrqq closed this Jul 2, 2019
@vrqq
Copy link
Contributor Author

vrqq commented Jul 2, 2019

Sorry, there's also existing another bug related the feed() function while file uploading.
With sending the upload request 'multipart/form-data' twice, only one can receive files.
This PR cannot fix the problem but only avoid crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant