This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Fixes #630 #631
Merged
Fixes #630 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull req is currently deployed on webdev for testing, although I suggest you go there and checkout master to see the problem first, so you can see that this fixes the problem. |
|
Looks good to me. Thanks for finding this @adamrp |
|
This is how I imagine @adamrp when he finds these obscure problems: |
ElDeveloper
added a commit
that referenced
this pull request
Feb 18, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the logic for tab selection. Tested on webdev using these kit IDs:
kydnk (verified on quarterbarrel)
rqfnh (not verified on quarterbarrel)
which belong to the same user in the test DB.